Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves the Cloudflare trusted proxy IP list from an embedded text resource to a committed, auto-generated C# source file, and updates the scheduled GitHub workflow to regenerate that source monthly.
Changes:
- Replace embedded
cloudflare-ips.txtfallback with a compiledCloudflareNetworkslist in a generated.g.cspartial. - Add an opt-in MSBuild target (
-p:UpdateCloudflareIPs=true) to download Cloudflare IPs and regenerateCloudflareNetworks.g.cs. - Update the monthly workflow to run the MSBuild regeneration and commit the regenerated source file.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Common/cloudflare-ips.txt | Removes the previously embedded Cloudflare IP list file. |
| Common/Utils/TrustedProxiesFetcher.cs | Switches fallback from embedded resource loading to CloudflareNetworks and makes the class partial. |
| Common/Utils/CloudflareNetworks.g.cs | Adds committed generated source containing the Cloudflare CIDR list as IPNetwork.Parse(...) calls. |
| Common/Common.csproj | Adds opt-in MSBuild download + source generation pipeline for Cloudflare networks. |
| .github/workflows/update-cloudflare-proxies.yml | Changes the monthly update job to regenerate and commit CloudflareNetworks.g.cs via dotnet build with the MSBuild property. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.